Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add process termination handling #23

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Add process termination handling #23

merged 4 commits into from
Feb 27, 2024

Conversation

truemiller
Copy link
Collaborator

@truemiller truemiller commented Feb 27, 2024 •
edited
Loading

  • ensures child processes are killed as well as parent processes
  • also handles sigint and sigterm signals, and unhandled exceptions
  • removed beforeQuit once check; if beforeQuit fails, user cannnot attempt to exit application again

mohandast52
mohandast52 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@mohandast52 mohandast52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

electron/processes.js Show resolved Hide resolved
electron/processes.js Outdated Show resolved Hide resolved
@truemiller truemiller merged commit 94199ab into main Feb 27, 2024
2 checks passed
@truemiller truemiller deleted the fix-process-killing branch February 27, 2024 14:42
0xArdi pushed a commit that referenced this pull request Oct 17, 2024
@Divya-Solulab
Merge pull request #23 from valory-xyz/fix/assets-limit
6ea37bc 
fix: add traded assets limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohandast52 mohandast52 mohandast52 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@truemiller @mohandast52